Skip to content

[Dashboard] feat: Add allowed operations to partner access control #6478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

[Dashboard] feat: Add allowed operations to partner access control #6478

merged 1 commit into from
Mar 18, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 15, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the partner management functionality within the ecosystem configuration by adding error handling, improving partner forms, and introducing allowed operations for partners.

Detailed summary

  • Added error handling for account and partner fetching.
  • Updated version in .github/composite-actions/install/action.yml.
  • Modified EcosystemPartnersSection to accept teamSlug.
  • Introduced fetchPartnerDetails and fetchPartners hooks for data fetching.
  • Enhanced AddPartnerForm and UpdatePartnerForm with redirect functionality.
  • Implemented AllowedOperationsSection for managing allowed signature operations.
  • Updated partner forms to include allowed operations and transaction restrictions.
  • Improved UI components and error messages for better user experience.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 8:46am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 8:46am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 8:46am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 8:46am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 8:46am

@vercel vercel bot temporarily deployed to Preview – wallet-ui March 15, 2025 06:30 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 15, 2025 06:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 15, 2025 06:30 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ea292c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 15, 2025 06:30 Inactive
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Mar 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review March 15, 2025 07:14
@joaquim-verges joaquim-verges requested review from a team as code owners March 15, 2025 07:14
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch from ec49015 to 646e6c8 Compare March 15, 2025 09:26
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 15, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 15, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 15, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 15, 2025 09:26 Inactive
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch from 646e6c8 to f040293 Compare March 16, 2025 22:29
@vercel vercel bot temporarily deployed to Preview – login March 16, 2025 22:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 16, 2025 22:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 16, 2025 22:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 16, 2025 22:29 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 16, 2025
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch from f040293 to 70a7dd7 Compare March 16, 2025 22:34
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 16, 2025 22:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 16, 2025 22:34 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 16, 2025 22:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 16, 2025 22:34 Inactive
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch from 70a7dd7 to 650b5c2 Compare March 16, 2025 22:35
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch from 650b5c2 to 42e710d Compare March 16, 2025 22:37
@joaquim-verges joaquim-verges requested a review from jnsdls as a code owner March 16, 2025 22:37
@codecov
Copy link

codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (f2e61b8) to head (ea292c9).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6478   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         875      875           
  Lines       54851    54851           
  Branches     3738     3738           
=======================================
  Hits        30062    30062           
  Misses      24695    24695           
  Partials       94       94
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.94 KB (0%) 939 ms (0%) 162 ms (+105.58% 🔺) 1.2 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 281 ms (+23.56% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 92 ms (+1276.5% 🔺) 204 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 74 ms (+2783.14% 🔺) 84 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 92 ms (+352.4% 🔺) 479 ms

@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch from 42e710d to 7b3291b Compare March 17, 2025 00:14
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch from 7b3291b to 2884f03 Compare March 17, 2025 08:32
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch from 2884f03 to ea292c9 Compare March 17, 2025 08:35
@joaquim-verges joaquim-verges merged commit cbc3bf1 into main Mar 18, 2025
33 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_feat_Add_allowed_operations_to_partner_access_control branch March 18, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@jnsdls jnsdls Awaiting requested review from jnsdls jnsdls is a code owner

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges